Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome! #276

Closed
ekristen opened this issue Sep 5, 2024 · 0 comments
Closed

Welcome! #276

ekristen opened this issue Sep 5, 2024 · 0 comments

Comments

@ekristen
Copy link
Owner

ekristen commented Sep 5, 2024

Welcome!

First of all welcome to this fork of aws-nuke. A big shout out and thank you to the original maintainers and contributors that came before over at rebuy-de/aws-nuke

IMPORTANT: if you were an approver/collaborator of any kind on the original project and have a desire to continue to do so, please reach out to me.

Documentation

Please read the documentation, it talks about deprecation, migrations and more. documentation website.

Status from Upstream

Please see #275 for a checklist of issues and pull requests that have already been incorporated into this fork.

Test

Please test your existing configuration out with this version. While I strove to be 100% compatible, it looks like there were a few changes in the original that never made it over. I'm addressing them as they are identified.

Contributions

Contributions are welcome! There are some new style guidelines and rules in place.

  • All commits must be signed.
  • All commits must follow semantic commit structure.
  • All PR titles must follow semantic commits structure.
  • There's a new format to the resource definitions, all existing resources are good examples.

Builds and Releases

These are 100% automated. Semantic Commit messages drive the versioning. Each merged PR results in a new version release. The exception being if an admin disables the workflow to merge many pull requests then re-enable. This helps gets builds out faster, bugs addressed quicker, and reduces the problems that are usually associated with human triggered releases.

@ekristen ekristen pinned this issue Sep 5, 2024
This was referenced Sep 12, 2024
This was referenced Oct 1, 2024
@ekristen ekristen closed this as completed Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant