Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add str$to_decimal() #55

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Conversation

etiennebacher
Copy link
Contributor

No description provided.

#' )
#' )
#' df$with_columns(numbers_decimal = pl$col("numbers")$str$to_decimal())
expr_str_to_decimal <- function(inference_length = 100) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first glance it is unclear what kind of role the number in the first argument plays, so for me it is surprising that this argument is not a named-only argument.

This is fine for now, but we probably need to update Python Polars.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably need to update Python Polars.

I've opened an issue pola-rs/polars#20564

Copy link
Owner

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eitsupi eitsupi merged commit 8c4b0bc into eitsupi:main Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants