Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows bug #822

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix windows bug #822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c845068
Fix windows problem
paul-bjorkstrand Jun 5, 2019
4f02093
Update CHANGELOG.md
paul-bjorkstrand Jun 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ Last public release: [![Maven Central](https://maven-badges.herokuapp.com/maven-

## Changelog

### 1.7.7

* Fix #749: Plugin will no longer fail during the node install step if it cannot delete the temporary directory.

### 1.7.6

* Fix #670: Plugin will no longer fail to install node.exe if node.exe already exists
Expand Down
8 changes: 7 additions & 1 deletion ...ugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/NodeInstaller.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,13 @@ private File getInstallDirectory() {
private void deleteTempDirectory(File tmpDirectory) throws IOException {
if (tmpDirectory != null && tmpDirectory.exists()) {
this.logger.debug("Deleting temporary directory {}", tmpDirectory);
FileUtils.deleteDirectory(tmpDirectory);
try {
FileUtils.deleteDirectory(tmpDirectory);
} catch (IOException e) {
this.logger.warn(
"Temporary directory could not be deleted, please delete it manually. Tempdir location: {}",
tmpDirectory.getPath());
}
}
}

Expand Down