-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add front support to BarrelImaging Calorimeter #608
Conversation
build support function is used to place the front support for BarrelImaging Calorimeter.
for more information, see https://pre-commit.ci
82489b1
to
d94bd95
Compare
In the barrel_interlayers.xml file, EcalBarrel_AvailThickness is currently defined as EcalBarrelRegion_thickness - EcalBarrel_BackSupportThickness. Not sure if it should be EcalBarrel_BackSupportThickness. |
@wdconinc I think that it was implemented first correctly by Chao, but then the walls and trapezoidal shape were gone. See the issue: #607 |
It shouldn't. The available thickness calculation should account both for front and back support structure. See for example here: epic/compact/ecal/barrel_interlayers.xml Line 84 in d94bd95
or here: epic/compact/ecal/barrel_interlayers.xml Line 95 in d94bd95
Also, the overall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please adjust the EcalBarrel_AvailThickness
and EcalBarrelRegion_thickness
as suggested in the last comment.
Reminder: We will be tagging a release in preparation for February campaign soon. When is this expected to be completed @AkshayaVijay ? |
Updated EcalBarrel_AvailThickness to account for both front and back support
Updated EcalBarrelRegion_thickness from 38 cm to 40 cm
Done |
Briefly, what does this PR introduce?
Adds the 0.5 cm aluminum front support
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.