Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add front support to BarrelImaging Calorimeter #608

Merged
merged 9 commits into from
Feb 7, 2024

Conversation

wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

Adds the 0.5 cm aluminum front support

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@github-actions github-actions bot added topic: barrel Mid-rapidity detectors topic: calorimetry labels Dec 12, 2023
@veprbl veprbl changed the title feat: add front support to BarrelIimaging Calorimeter feat: add front support to BarrelImaging Calorimeter Jan 29, 2024
@AkshayaVijay AkshayaVijay force-pushed the front-support-barrel-imaging-calorimeter branch from 82489b1 to d94bd95 Compare February 3, 2024 23:29
@AkshayaVijay
Copy link
Contributor

Img_geometry_sector_1
ScFi_geometry_sector_1

@wdconinc
Copy link
Contributor Author

wdconinc commented Feb 4, 2024

This is interesting. The front support plate is correct, but I am now noticing that we probably have a problem with how the trays are coded up. It seems the side should be flat but it seems the trays have a rectangular cross section instead of a trd.

Marked up a phone screenshot with the straightest line I can draw in freehand...
Screenshot_20240203-181239.png

@wdconinc wdconinc marked this pull request as ready for review February 4, 2024 00:18
@AkshayaVijay
Copy link
Contributor

In the barrel_interlayers.xml file, EcalBarrel_AvailThickness is currently defined as EcalBarrelRegion_thickness - EcalBarrel_BackSupportThickness. Not sure if it should be EcalBarrel_BackSupportThickness.

@mariakzurek
Copy link
Contributor

This is interesting. The front support plate is correct, but I am now noticing that we probably have a problem with how the trays are coded up. It seems the side should be flat but it seems the trays have a rectangular cross section instead of a trd.

Marked up a phone screenshot with the straightest line I can draw in freehand... Screenshot_20240203-181239.png

@wdconinc I think that it was implemented first correctly by Chao, but then the walls and trapezoidal shape were gone. See the issue: #607

@mariakzurek
Copy link
Contributor

In the barrel_interlayers.xml file, EcalBarrel_AvailThickness is currently defined as EcalBarrelRegion_thickness - EcalBarrel_BackSupportThickness. Not sure if it should be EcalBarrel_BackSupportThickness.

It shouldn't. The available thickness calculation should account both for front and back support structure. See for example here:

value="min(EcalBarrelImagingLayers_nMax,

or here:

value="max(0, EcalBarrel_AvailThickness-EcalBarrel_ImagingPartThickness)"/>

Also, the overall EcalBarrelRegion_thickness should be increased to have safe margin. Otherwise, when we add extra layers (like for example front aluminum plate) we can artificially shrink the active SciFi/Pb area. You can see here: https://indico.bnl.gov/event/20473/contributions/84620/ that the Calo is now ~ 40 cm in CAD model. So we should make EcalBarrelRegion_thickness at least 40 cm. https://github.com/eic/epic/blob/main/compact/definitions.xml#L547

Copy link
Contributor

@mariakzurek mariakzurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the EcalBarrel_AvailThickness and EcalBarrelRegion_thickness as suggested in the last comment.

@rahmans1
Copy link
Contributor

rahmans1 commented Feb 6, 2024

Reminder: We will be tagging a release in preparation for February campaign soon. When is this expected to be completed @AkshayaVijay ?

Updated EcalBarrel_AvailThickness to account for both front and back support
Updated EcalBarrelRegion_thickness from 38 cm to 40 cm
@AkshayaVijay
Copy link
Contributor

Please adjust the EcalBarrel_AvailThickness and EcalBarrelRegion_thickness as suggested in the last comment.

Done

@wdconinc wdconinc added this pull request to the merge queue Feb 7, 2024
Merged via the queue into main with commit 33f186f Feb 7, 2024
89 checks passed
@wdconinc wdconinc deleted the front-support-barrel-imaging-calorimeter branch February 7, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants