-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmarks/tracking_performances: implement CI #29
Conversation
1207f8d
to
6c3f0ff
Compare
6c3f0ff
to
399b4c9
Compare
Thanks @veprbl for this work. Is it running? I want to see the output. From Matt's (simulation campaign) and mine (local simulation with latest tag) presentation in tracking you can see each simulation campaign is producing different performances. The idea is when you change something major then we can run with latest tag and can check the performances. If there are some strange feature, I can easily spot them. You can also make the epic_tracking_only.xml as the default everywhere with the latest tag. Even we can print the graph in the log file if required then we can match the numbers (momentum resolutions), they will be the same. |
Hi @Simple-Shyam, this is, indeed, now running. You can check plots from a latest run at https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/3474456/artifacts/browse/results/tracking_performances/ . For now, it's all for the latest container and simulations are only generated on the fly, the campaign processing is no implemented on CI anywhere yet. I still need to figure out a good procedure for that. The |
Thanks @veprbl for this task. It's very nice that I can see the performances now. You can see a decrease at low momentum (nonphysical) and higher eta which I am trying to understand. I also shared the code with Torri which works with simulation campaign (automatically). You can remove that script or I can? For the numbers, if you want we can print the graph (truth and real both calling graph->Print()) in to the text or log file which can be directly be compared with some reference values visually or we put a difference in terms of percentage or json file also fine. |
I have a further comment about the plots why did you remove the debug plots directory? If some strange behavior is seen in the tracking performances plot then I go to 1 dimensional Gaussian fit (debug directory) to check whether things are fine or not? Also can we increase the number of events (50k, just asking?) so that we can see the decrease behavior at large eta with less uncertainties. |
I didn't remove the debug directory. If you look at the last Snakemake rule, it does aggregation into |
Thank you Dmitry. It will be helpful for me. I need to check to understand decrease at low momentum and at large eta. |
This enables tracking_performances as a benchmark running on eicweb. This also adds a Snakefile that can be used interactively. The simulations produced should match the blueprint of the official productions, so that the workflow can be extended to running over campaigns next.