Use fs-extra instead of ncp to avoid race condition #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should add that with this change, the project I was consistently getting broken deploys with before has successfully deployed several times in a row now. |
|
Nice work. Released in 1.3.2. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been hitting an issue where large files were being committed to my deploy branch before they were completely copied, and after hunting around for a forgotten promise return in my own code, eventually found my way to this ncp issue. It looks like there hasn't been much activity on that project for a while, and there are a number of similar issues sitting open.
Since we're already using
fs-extrahere, I droppedncpin favor of just using thecopyimplementation there (which I believe was originally based onncp, but has continued to be maintained).