fix: Add timeout to retrieve_latest_base_ami.py #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were seeing some connections hang. This ensures that we can kill misbehaving attempts and then retry them.
robrap
approved these changes
Jan 7, 2025
| @@ -127,7 +127,8 @@ def _backoff_logger(details): | |||
| max_tries=5, jitter=backoff.random_jitter, on_backoff=_backoff_logger, | |||
| ) | |||
| def get_with_retry(url): | |||
| data = requests.get(url) | |||
| # Set timeout to 1 minute to ensure open connections get killed. | |||
There was a problem hiding this comment.
I don't think the comment is needed, but it won't hurt (until someone changes the timeout and forgets to change the comment. 😉 )
There was a problem hiding this comment.
🙏 we delete this code before then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing some connections hang. This ensures that we can kill misbehaving attempts and then retry them.
edx/edx-arch-experiments#886