Skip to content

Commit

Permalink
test: Remove support for Node 18
Browse files Browse the repository at this point in the history
  • Loading branch information
BilalQamar95 committed Oct 10, 2024
1 parent b180478 commit 3a58401
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ jobs:
python-version: ["3.8", "3.12"]
os: [ubuntu-20.04]
toxenv: [django42]
node: [18, 20]
env:
DATA_API_VERSION: "latest"
steps:
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ WORKDIR ${INSIGHTS_CODE_DIR}/
# insights service config commands below
RUN pip install --no-cache-dir -r ${INSIGHTS_CODE_DIR}/requirements/production.txt

RUN nodeenv ${INSIGHTS_NODEENV_DIR} --node=18.20.2 --prebuilt \
&& npm install -g npm@10.5.x
RUN nodeenv ${INSIGHTS_NODEENV_DIR} --node=20.15.1 --prebuilt \
&& npm install -g npm@10.7.x

# Tried to cache the dependencies by copying related files after the npm install step but npm post install fails in that case.
COPY . ${INSIGHTS_CODE_DIR}/
Expand Down

0 comments on commit 3a58401

Please sign in to comment.