Add only available themes to site config #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manan-memon
force-pushed
the
manan/EDLY-6904
branch
from
9ada798 to
4fc38b9
Compare
manan-memon
changed the title
manan-memon
requested review from
muhammadali286,
Anas-hameed and
taimoor-ahmed-1
taimoor-ahmed-1
requested changes
Nov 14, 2024
credentials/apps/edx_credentials_extensions/edly_credentials_app/api/v1/views/edly_sites.py
Show resolved
Hide resolved
muhammadali286
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that when creating credentials site using api, only available themes are used for site configuration. Using any other name results in internal server error on credentials.
JIRA: https://edlyio.atlassian.net/browse/EDLY-6904