Skip to content

Commit

Permalink
ci: fix artifact naming problems in e2e test (#2948)
Browse files Browse the repository at this point in the history
* Fix potentially artifact naming in weekly tests
* Use e2e prefix for artifact naming in e2e-benchmark

---------

Signed-off-by: Daniel Weiße <[email protected]>
  • Loading branch information
daniel-weisse authored Feb 27, 2024
1 parent 6f60cee commit 8051837
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
9 changes: 6 additions & 3 deletions .github/actions/e2e_benchmark/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ inputs:
awsOpenSearchPwd:
description: "AWS OpenSearch Password to upload the results."
required: false
artifactNameSuffix:
description: "Suffix for artifact naming."
required: true
encryptionSecret:
description: 'The secret to use for encrypting the artifact.'
required: true
Expand Down Expand Up @@ -103,7 +106,7 @@ runs:
uses: ./.github/actions/artifact_upload
with:
path: "out/fio-constellation-${{ inputs.cloudProvider }}.json"
name: "fio-constellation-${{ inputs.cloudProvider }}.json"
name: "fio-constellation-${{ inputs.artifactNameSuffix }}.json"
encryptionSecret: ${{ inputs.encryptionSecret }}

- name: Run knb benchmark
Expand All @@ -125,7 +128,7 @@ runs:
uses: ./.github/actions/artifact_upload
with:
path: "out/knb-constellation-${{ inputs.cloudProvider }}.json"
name: "knb-constellation-${{ inputs.cloudProvider }}.json"
name: "knb-constellation-${{ inputs.artifactNameSuffix }}.json"
encryptionSecret: ${{ inputs.encryptionSecret }}

- name: Parse results, create diagrams and post the progression summary
Expand All @@ -146,7 +149,7 @@ runs:
with:
path: >
benchmarks/constellation-${{ inputs.cloudProvider }}.json
name: "benchmarks-${{ inputs.attestationVariant }}"
name: "benchmarks-${{ inputs.artifactNameSuffix }}"
encryptionSecret: ${{ inputs.encryptionSecret }}

- name: Assume AWS role to retrieve and update benchmarks in S3
Expand Down
1 change: 1 addition & 0 deletions .github/actions/e2e_test/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,7 @@ runs:
awsOpenSearchUsers: ${{ inputs.awsOpenSearchUsers }}
awsOpenSearchPwd: ${{ inputs.awsOpenSearchPwd }}
encryptionSecret: ${{ inputs.encryptionSecret }}
artifactNameSuffix: ${{ steps.create-prefix.outputs.prefix }}

- name: Run constellation verify test
if: inputs.test == 'verify'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-upgrade.yml
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ jobs:
if: always()
uses: ./.github/actions/artifact_upload
with:
name: upgrade-logs
name: upgrade-logs-${{ inputs.attestationVariant }}
path: >
node-operator.logs
node-maintenance-operator.logs
Expand Down

0 comments on commit 8051837

Please sign in to comment.