chore(update_channel): better errors #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build b51ed9469c247cec308c7d28166a562aedf5f225-PR-771Details
💛 - Coveralls |
lusergit
force-pushed
the
chore/errors-update-channel
branch
2 times, most recently
from
158b288 to
7e9c7e0
Compare
noaccOS
reviewed
Dec 10, 2024
backend/lib/edgehog/update_campaigns/update_channel/changes/relate_target_groups.ex
Outdated
Show resolved
Hide resolved
lusergit
force-pushed
the
chore/errors-update-channel
branch
3 times, most recently
from
0173107 to
332fea1
Compare
lusergit
force-pushed
the
chore/errors-update-channel
branch
2 times, most recently
from
c82adb8 to
9a5e7aa
Compare
noaccOS
requested changes
Jan 7, 2025
backend/lib/edgehog/update_campaigns/update_channel/error_handler.ex
Outdated
Show resolved
Hide resolved
lusergit
force-pushed
the
chore/errors-update-channel
branch
2 times, most recently
from
d0185aa to
ed65535
Compare
noaccOS
approved these changes
Jan 7, 2025
backend/test/edgehog_web/schema/mutation/update_update_channel_test.exs
Outdated
Show resolved
Hide resolved
lusergit
force-pushed
the
chore/errors-update-channel
branch
2 times, most recently
from
38d7e23 to
278b643
Compare
|
This depends on ash-project/ash_graphql#257 and ash-project/ash_graphql#253, both have been merged but have yet to be integrated in the next release. When it will be ready we can bump up the ash_graphql and ash version and re open the PR for review. |
lusergit
force-pushed
the
chore/errors-update-channel
branch
3 times, most recently
from
ca658ed to
b51ed94
Compare
@lusergit here it is: https://github.com/ash-project/ash_graphql/releases/tag/v1.5.0 |
When creating and updating an update channel, target group ids are validated to be available, meaning: - they are present in the DB - they are not related to any other update channel closes edgehog-device-manager#529 Signed-off-by: Luca Zaninotto <[email protected]>
lusergit
force-pushed
the
chore/errors-update-channel
branch
from
b51ed94 to
5374612
Compare
davidebriani
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating and updating an update channel, target group ids are validated to be available, meaning:
closes #529