Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward port 'release-0.9' into main #768

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

noaccOS
Copy link
Collaborator

@noaccOS noaccOS commented Dec 9, 2024

No description provided.

noaccOS and others added 5 commits December 9, 2024 16:15
previously, calling Ash.destroy! on a base image would crash the program
because Edgehog.BaseImages.Uploaders.BaseImage.filename/2 would try to
access the field `base_image_version` of a BaseImage, which does not
exist

Signed-off-by: Francesco Noacco <[email protected]>
…xmlmoou

fix(bucket_storage): image deletion
- Reconciling tenant is done directly in seeds when it gets created
- Edgehog in 5 minutes does no longer instruct users to manually
  reconcile the tenant with astarte

Signed-off-by: Luca Zaninotto <[email protected]>
chore(seeds): reconcile tenant when seeding
Signed-off-by: Francesco Noacco <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build cd77593215fc2d9d7efbe5468b5fb581ee3156ae-PR-768

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 80.512%

Files with Coverage Reduction New Missed Lines %
lib/edgehog/base_images/bucket_storage.ex 3 0.0%
Totals Coverage Status
Change from base Build d2b42c18d38e9113f662489ca33ff8c66dce5e96: -0.05%
Covered Lines: 1227
Relevant Lines: 1524

💛 - Coveralls

@davidebriani davidebriani merged commit dd0722e into edgehog-device-manager:main Dec 9, 2024
8 checks passed
@noaccOS noaccOS deleted the push-oylpmwmlpnuz branch December 9, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants