Refactor Page Component and Add Breadcrumb Navigation #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarBrbutovic
force-pushed
the
add_breadcrumbs
branch
from
5bf2fd5 to
fdad1c1
Compare
davidebriani
approved these changes
Dec 5, 2024
- Updated the `Route` enum to nest the release path under the application context (`/applications/:applicationId/release/:releaseId`) - Modified the `RELEASES_TABLE_FRAGMENT` to include the `application.id` field for constructing the updated route - Adjusted the `columns` definition to pass the `applicationId` as a parameter in the `Link` for release navigation Signed-off-by: Omar <[email protected]>
OmarBrbutovic
force-pushed
the
add_breadcrumbs
branch
from
fdad1c1 to
11b4430
Compare
OmarBrbutovic
force-pushed
the
add_breadcrumbs
branch
from
11b4430 to
0adb3bc
Compare
- Refactor the `Page` component to include breadcrumb navigation within the application Signed-off-by: Omar <[email protected]>
- Replaced the test for rendering the `title` property with a test for the `BreadcrumbItems` component Signed-off-by: Omar <[email protected]>
npm run i18n:extract Signed-off-by: Omar <[email protected]>
OmarBrbutovic
force-pushed
the
add_breadcrumbs
branch
from
0adb3bc to
9f148be
Compare
davidebriani
merged commit 72a8b42
into
edgehog-device-manager:feature/application-management
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the
Pagecomponent to include breadcrumb navigation within the applicationScreenshots