Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forwarding of scan requests #34

Merged
merged 6 commits into from
Nov 27, 2024
Merged

Add forwarding of scan requests #34

merged 6 commits into from
Nov 27, 2024

Conversation

ChrisspyB
Copy link
Member

wip. todo:

  • Make sure non-forwarded requests still work as expected.

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 43.56061% with 149 lines in your changes missing coverage. Please review.

Project coverage is 61.62%. Comparing base (be8752e) to head (cb4a1ec).

Files with missing lines Patch % Lines
src/gribjump/Forwarder.cc 0.00% 54 Missing ⚠️
src/gribjump/remote/Request.cc 0.00% 24 Missing ⚠️
src/gribjump/remote/RemoteGribJump.cc 21.73% 18 Missing ⚠️
src/tools/gribjump-scan.cc 54.54% 15 Missing ⚠️
src/gribjump/Task.cc 27.77% 13 Missing ⚠️
src/gribjump/Engine.cc 67.64% 11 Missing ⚠️
src/gribjump/remote/Request.h 0.00% 6 Missing ⚠️
src/gribjump/URIHelper.h 72.72% 3 Missing ⚠️
src/gribjump/remote/GribJumpUser.cc 0.00% 2 Missing ⚠️
src/gribjump/Config.h 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #34      +/-   ##
===========================================
- Coverage    62.01%   61.62%   -0.39%     
===========================================
  Files           85       88       +3     
  Lines         4454     4576     +122     
  Branches       492      498       +6     
===========================================
+ Hits          2762     2820      +58     
- Misses        1692     1756      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisspyB ChrisspyB marked this pull request as ready for review November 26, 2024 17:21
@ChrisspyB ChrisspyB merged commit 95ee5db into develop Nov 27, 2024
102 checks passed
@ChrisspyB ChrisspyB deleted the feature/forward-scan branch November 29, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants