Tool cleanup: remove dependency on fdb5 tool #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #23 +/- ##
===========================================
+ Coverage 54.04% 58.72% +4.67%
===========================================
Files 81 83 +2
Lines 4315 4356 +41
Branches 480 479 -1
===========================================
+ Hits 2332 2558 +226
+ Misses 1983 1798 -185 ☔ View full report in Codecov by Sentry. |
|
Todo: also run the scan tests on the non-hpc CI |
|
TODO: Change the CI branch back to develop, once corresponding eckit PR is merged (ecmwf/eckit#145) |
Merged
ChrisspyB
force-pushed
the
feature/tool-cleanup
branch
from
13a64e3 to
ad65232
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And a small tidy up of the tool classes