Minor tidy up

ecmwf · Dec 9, 2024 · c88c79a · c88c79a
1 parent d910428
commit c88c79a
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 9 deletions.
diff --git a/src/gribjump/Engine.cc b/src/gribjump/Engine.cc
@@ -172,7 +172,7 @@ TaskOutcome<size_t> Engine::scan(const MarsRequests& requests, bool byfiles) {
 
     std::vector<eckit::URI> uris = FDBLister::instance().URIs(requests);
 
-    // XXX do we explicitly need this?
+    /// @todo do we explicitly need this?
     if (uris.empty()) {
         MetricsManager::instance().set("count_scanned_fields", 0);
         return {0, TaskReport()};

diff --git a/src/gribjump/Engine.h b/src/gribjump/Engine.h
@@ -35,7 +35,6 @@ class Engine {
     Engine();
     ~Engine();
 
-    // ResultsMap extract(ExtractionRequests& requests);
     TaskOutcome<ResultsMap> extract(ExtractionRequests& requests);
 
     // byfiles: scan entire file, not just fields matching request

diff --git a/src/gribjump/LocalGribJump.cc b/src/gribjump/LocalGribJump.cc
@@ -119,10 +119,6 @@ ResultsMap LocalGribJump::extract(const std::vector<std::string>& requests, cons
 }
 
 std::map<std::string, std::unordered_set<std::string>> LocalGribJump::axes(const std::string& request, int level) {
-
-    // Note: This is likely to be removed from GribJump, and moved to FDB.
-    // Here for now to support polytope.
-
     return Engine().axes(request, level);
 }
 

diff --git a/src/gribjump/remote/Request.h b/src/gribjump/remote/Request.h
@@ -28,7 +28,7 @@ namespace gribjump {
 //----------------------------------------------------------------------------------------------------------------------
 
 class Request {
-public: // methods
+public:
 
     Request(eckit::Stream& stream);
 
@@ -45,8 +45,8 @@ class Request {
 protected: // members
 
     eckit::Stream& client_;
-    Engine engine_; //< Engine and schedule tasks based on request // XXX Can we now remove this?
-    TaskReport report_; // 
+    Engine engine_;
+    TaskReport report_;
     uint64_t id_;
 };