Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issue on conda-forge ECFLOW-1987 #132

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

marcosbento
Copy link
Collaborator

This allows to find libcrypt.so by full path, and avoid being dependent on the compiler directory search.

Re ECFLOW-1987

@marcosbento marcosbento changed the title Add FindCrypt.cmake module Fix build issue on conda-forge ECFLOW-1987 Nov 4, 2024
@marcosbento marcosbento marked this pull request as ready for review November 4, 2024 18:17
@marcosbento
Copy link
Collaborator Author

Changes cherry picked to be included in 5.13.6 -- see 9876f2d.

@marcosbento marcosbento force-pushed the fix/conda-forge-unable-to-find-crypt branch 3 times, most recently from d9576f8 to b9749b4 Compare December 11, 2024 16:30
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.87%. Comparing base (e21f499) to head (62818eb).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #132      +/-   ##
===========================================
- Coverage    48.88%   48.87%   -0.02%     
===========================================
  Files         1188     1188              
  Lines        98305    98305              
  Branches     14745    14746       +1     
===========================================
- Hits         48060    48046      -14     
- Misses       50245    50259      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This allows to find libcrypt.so by full path, and avoid being dependent
on the compiler directory search.

Re ECFLOW-1987
@marcosbento marcosbento force-pushed the fix/conda-forge-unable-to-find-crypt branch from b9749b4 to 62818eb Compare December 16, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants