Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable support for HTTP communication between components ECFLOW-1957 #121

Draft
wants to merge 23 commits into
base: develop
Choose a base branch
from
Draft

Enable support for HTTP communication between components ECFLOW-1957 #121

wants to merge 23 commits into from

Conversation

marcosbento
Copy link
Collaborator

No description provided.

@marcosbento marcosbento force-pushed the feature/support_http_comms branch 3 times, most recently from 5e20a18 to 92016f8 Compare September 23, 2024 11:37
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 45.97070% with 295 lines in your changes missing coverage. Please review.

Project coverage is 48.91%. Comparing base (e21f499) to head (7f670da).

Files with missing lines Patch % Lines
libs/client/test/harness/SCPort.cpp 28.78% 47 Missing ⚠️
libs/test/harness/TestFixture.cpp 0.00% 45 Missing ⚠️
Viewer/ecflowUI/src/ServerListDialog.cpp 0.00% 27 Missing ⚠️
libs/server/src/ecflow/server/HttpServer.cpp 80.19% 20 Missing ⚠️
libs/core/src/ecflow/core/EcfPortLock.hpp 0.00% 18 Missing ⚠️
libs/base/src/ecflow/base/ServerProtocol.hpp 22.22% 14 Missing ⚠️
libs/server/test/TestServer.cpp 39.13% 14 Missing ⚠️
libs/test/harness/ScratchDir.hpp 0.00% 14 Missing ⚠️
Viewer/ecflowUI/src/ServerHandler.cpp 0.00% 13 Missing ⚠️
Viewer/ecflowUI/src/ServerList.cpp 0.00% 13 Missing ⚠️
... and 22 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #121      +/-   ##
===========================================
+ Coverage    48.88%   48.91%   +0.02%     
===========================================
  Files         1188     1192       +4     
  Lines        98305    98600     +295     
  Branches     14745    14801      +56     
===========================================
+ Hits         48060    48226     +166     
- Misses       50245    50374     +129

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcosbento marcosbento force-pushed the feature/support_http_comms branch 3 times, most recently from 798ae74 to b1ca0fa Compare September 24, 2024 12:03
@marcosbento marcosbento force-pushed the feature/support_http_comms branch 2 times, most recently from df873ea to 6d66c4f Compare October 2, 2024 13:29
@marcosbento marcosbento force-pushed the feature/support_http_comms branch 5 times, most recently from 3a68a7b to a6b987c Compare October 20, 2024 07:47
@marcosbento marcosbento force-pushed the feature/support_http_comms branch 2 times, most recently from 6a27b3e to 3eb760f Compare October 21, 2024 11:34
@marcosbento marcosbento force-pushed the feature/support_http_comms branch from 292a140 to 5549420 Compare November 5, 2024 13:19
@marcosbento marcosbento force-pushed the feature/support_http_comms branch 2 times, most recently from 970c6c9 to b886c88 Compare December 11, 2024 15:59
@marcosbento
Refactor DefaultServer class template
98a9ca4 
Re ECFLOW-1957
@marcosbento
Enable HTTP connection between Client/Server
faf0846 
Re ECFLOW-1957
@marcosbento
Enable UI to use HTTP connection
c24625c 
Re ECFLOW-1957
@marcosbento
Enable REST/UDP proxies to use HTTP connection
bdf632e 
Also, fix an eventual race condition accessing:
 - Ecf::state_change_no_ and Ecf::state_modify_no_
Apart from making these global (instead of thread_local),
the Http library is restricted to the use of a single thread

Re ECFLOW-1957
@marcosbento
Enable ecFlow REST API tests using HTTP backend
818bb53 
Re ECFLOW-1957
@marcosbento
Improve TestFixture by extracting ScratchDir
9a14d3f 
Re ECFLOW-1957
@marcosbento
Improve TestFixture by extracting LocalServerLauncher
0ca2e41 
Re ECFLOW-1957
@marcosbento
Enable s_test with HTTP backend
9826fce 
Re ECFLOW-1957
@marcosbento
Simplify tests AbortCmd and WaitCmd
c532a36 
Re ECFLOW-1957
@marcosbento
Correct typo in source code comment
ebdb814 
Re ECFLOW-1957
@marcosbento
Replace deprecated use of BOOST_GLOBAL_FIXTURE
ad24dc9 
BOOST_GLOBAL_FIXTURE has been deprecated with Boost 1.65, to be
replaced by BOOST_TEST_GLOBAL_FIXTURE.

Re ECFLOW-1957
@marcosbento
Allow REST API tests to run in parallel
b52167a 
Re ECFLOW-1957
@marcosbento
Remove the use of std::filesystem
ed3f254 
Re ECFLOW-1957
@marcosbento
Ensure parallel s_test* do not use same port or directory
1a6f30c 
Re ECFLOW-1957
@marcosbento
Test ecFlow Python using HTTP ecFlow server
6de2a5d 
Re ECFLOW-1957
@marcosbento
Enable HTTPS on the Client side
877fc76 
Re ECFLOW-1957
@marcosbento
Use notion of selected Protocol
af2ae65 
- use Protocol value instead of flags isSsl, isHttp, isHttps in the ecFlowUI implementation

Re ECFLOW-1957
@marcosbento
Move test methods in ClientInvoker to SCPort
71295dd 
- create `harness` libraries to support the tests

Re ECFLOW-1957
@marcosbento
Use notion of selected Protocol
61782ac 
- use Protocol value instead of flags isSsl, isHttp, isHttps in the server/client implementation

Re ECFLOW-1957
@marcosbento
Add description to HttpServer
3a03656 
Re ECFLOW-1957
@marcosbento
Correct #include guards
ae86dd6 
Re ECFLOW-1957
@marcosbento
Correct outstanding compilation warnings
e4c47d0 
Re ECFLOW-1957
@marcosbento
Update default HTTP connection timeouts
7f670da 
Re ECFLOW-1957
@marcosbento marcosbento force-pushed the feature/support_http_comms branch from b886c88 to 7f670da Compare December 16, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcosbento @codecov-commenter