Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixed support #2409

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Mixed support #2409

wants to merge 35 commits into from

Conversation

kchobantonov
Copy link
Contributor

@kchobantonov kchobantonov commented Dec 30, 2024 •
edited
Loading

  1. provide support for mixed types
  2. fix clearing of inputs when not under an object - e.g. string once cleared will become empty string rather than to return undefined to remove the property from the parent object
  3. fix date controls, now the date can show year, year/month and etc. depending on the control option views
  4. improve the performance to convert dayjs format into maska format function
  5. fixing the :key to at least have the collection size into the key so when the size changes the vue will not reuse html elements leaving attributes like id unchanged
  6. add more examples to show how the mixed control can be used
  7. use arraySchema from the mapped values rather than using Resolve
  8. minor UI changes to use less space
  9. core changes : use the provided schema when the resolve failed, make sure that boolean is valid schema as well - e.g. items: true is valid schema (Note: the last change for the items to be boolean was reverted back since more code should be adjusted - maybe a future improvement)

@kchobantonov
initial mixed renderer support
f8c2caf
@kchobantonov
organize imports
c078710
@kchobantonov
handle correctly the clear where if the property that is cleared in n…
ece92ac 
…ot part of the object that has the property defined in properties then to not clear it - e.g. send undefined value
@kchobantonov
update controls to properly send clear value
bd28667
@kchobantonov
update control to properly send clear value and add support for UI op…
a62efb4 
…tions.views
@kchobantonov
optimize the performance of convertDayjsToMaskaFormat function
4bc6b73
@kchobantonov
fix key property where the value is not based on data primary key but…
4716a43 
… based on index - e.g. prevent reusing elements when the array change size which will cause id properties for example to not have correct value
@kchobantonov
organize imports
807546f
@kchobantonov
add translations
25300db
@kchobantonov
make sure that we use new date so that the proxyModel is correctly no…
81c81db 
…tified for the new value
@kchobantonov
no need to check props?.schema?.properties
3a4f2b9
@kchobantonov
proper implementation for the optional translator
6b5dca8
@kchobantonov
change the way how we determine if default value should be returned
2f96aef
@kchobantonov
use control.arraySchema instead of Resolve
cc44091
@kchobantonov
use control.arraySchema instead of Resolve, make the header to not ta…
d460e6c 
…ke so much space
@kchobantonov
clean up class
1f24b21
@kchobantonov
use less space
d716953
@kchobantonov
do not render the div if nothing to renders as children
498cbf1
@kchobantonov
use more descriptive name
72e17d0
@kchobantonov
if we are in dynamic context then always prefer the VerticalLayout ov…
89bfb0b 
…er the Group
@kchobantonov
if the schema is an object that is selected because of mixed type the…
ef24610 
…n also allow such case to be handled by the object renderer
@kchobantonov
when the mixed renderer provides the exact schema to use then there i…
492e5fd 
…s no need to resolve that schema just use it
@kchobantonov
add core schema meta-schema as example
434a1f9
@kchobantonov
Merge branch 'master' into mixed-support
532fa9f
@kchobantonov
resolve schema like 'items': true
22760af
@kchobantonov
add jsonschema example
8a1b523
@kchobantonov
symplify how we determine that the object renderer should be used whe…
1d51ee8 
…n the mixed renderer selected object type
@kchobantonov
items in draft7 can accept boolean
770531a
@kchobantonov
add generic json editor example
6ead876
@kchobantonov
fix items.type
b7460ab
@netlify Netlify
Copy link

netlify bot commented Dec 30, 2024 •
edited
Loading

✅ Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 40dc34f
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/677f071b2045fe000933970f
😎 Deploy Preview https://deploy-preview-2409--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kchobantonov
Copy link
Contributor Author

@sdirix please review - checkout the new examples

  1. https://deploy-preview-2409--jsonforms-examples.netlify.app/vue-vuetify/#mixed
  2. https://deploy-preview-2409--jsonforms-examples.netlify.app/vue-vuetify/#mixed-object
  3. https://deploy-preview-2409--jsonforms-examples.netlify.app/vue-vuetify/#json-editor
  4. https://deploy-preview-2409--jsonforms-examples.netlify.app/vue-vuetify/#jsonschema

For example 3 the easier way to see that is to copy any example json data, provided it in the example ( Data tab - save it) and see the result in the Demo tab

@coveralls
Copy link

Coverage Status

coverage: 82.439% (-0.07%) from 82.504%
when pulling e3c8b3c on kchobantonov:mixed-support
into 1dd3960 on eclipsesource:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kchobantonov @coveralls