Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include incubation feature in setup #546

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

merks
Copy link
Contributor

@merks merks commented Dec 26, 2023

Use DisplayRealm.getReal rather than SWTObservables.getRealm. Accommodate generates in generics in GEF.

#527

@merks
Copy link
Contributor Author

merks commented Dec 26, 2023

@lcaron

The build are failing like for this PR for me locally as well. I think it needs version changes like this:

image

What I hope to get working is a local launch configuration for the Tycho build like this:

image

If I get that working, I can better determine which projects are build built and should be in the workspace and then eventually automating the publishing of update sites like I've done for other projects, most recently for GEF Classic...

@lcaron
Copy link
Contributor

lcaron commented Jan 22, 2024

@merks I've fixed the build. Can you please rebase and keep me informed ?

@merks
Copy link
Contributor Author

merks commented Jan 22, 2024

FYI, I'm out of office until Friday. Hopefully I'll have time then.

@merks
Copy link
Contributor Author

merks commented Jan 23, 2024

I think I have some mistaken conceptions about what should be in the target platform... I can't look at this further until I'm back.

Use Realm.getDefault rather than SWTObservables.getRealm.
Accommodate generates in generics in GEF.

eclipse#527
@merks
Copy link
Contributor Author

merks commented Jan 23, 2024

Okay, last try for today. I was able to do both builds locally now...

@merks
Copy link
Contributor Author

merks commented Jan 25, 2024

@lcaron @wimjongman

This can be merged and then I can look again at how we might improve the production of update sites...

@wimjongman
Copy link
Contributor

Wonderful, thanks Ed.

@wimjongman wimjongman merged commit 6c538c0 into eclipse:master Jan 25, 2024
5 checks passed
@wimjongman
Copy link
Contributor

Is it easier for you if we make you a committer?

@merks merks deleted the issue-527-incubation branch January 25, 2024 13:27
@merks
Copy link
Contributor Author

merks commented Jan 25, 2024

Yes, that would allow me to prototype everything without bothering you folks nearly as much...

@lcaron
Copy link
Contributor

lcaron commented Jan 25, 2024

Thank you Ed. You deserve to be a commiter. I'm gonna submit the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants