Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug #516 - Use latest Tycho and Java 17 for building #543

Conversation

lcaron
Copy link
Contributor

@lcaron lcaron commented Dec 23, 2023

Move Tycho version (and move to JDK 17)

@lcaron lcaron force-pushed the bugfix/Issue_516_Use_latest_Tycho_and_Java_17_for_building branch from 6af7dcc to a1ba963 Compare December 23, 2023 17:35
Move Tycho version (and move to JDK 17), udpate jobs
@lcaron lcaron force-pushed the bugfix/Issue_516_Use_latest_Tycho_and_Java_17_for_building branch from a1ba963 to 1fab50f Compare December 23, 2023 17:45
@@ -2,6 +2,6 @@
<extension>
<groupId>org.eclipse.tycho.extras</groupId>
<artifactId>tycho-pomless</artifactId>
<version>2.5.0</version>
<version>3.0.4</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<version>3.0.4</version>
<version>4.0.4</version>

The latest Tycho version as of today is 4.0.4

@@ -22,7 +22,7 @@ Contributors:

<properties>

<tycho-version>2.6.0</tycho-version>
<tycho-version>3.0.4</tycho-version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to use a maven.config file and then share the Tycho version for extension/pom in that file like described here: https://tycho.eclipseprojects.io/doc/latest/StructuredBuild.html#pomless-builds

@laeubi
Copy link
Member

laeubi commented Dec 26, 2023

There is no <tycho-extras-version> anymore for a long time so you probably want to replace that with search+replace

@Boarschti42
Copy link

Boarschti42 commented Dec 30, 2023

Hi, i recommend using

<extensions>
    <extension>
        <groupId>org.eclipse.tycho</groupId>
        <artifactId>tycho-build</artifactId>
        <version>4.0.4</version>
    </extension>
</extensions>

instead of tycho-pomless since this is the current way suggested.

@merks
Copy link
Contributor

merks commented Feb 11, 2024

This is obsolete with the changes from #559

@merks merks closed this Feb 11, 2024
@merks merks deleted the bugfix/Issue_516_Use_latest_Tycho_and_Java_17_for_building branch February 11, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants