Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper identifiers as identifiers #1708

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Use proper identifiers as identifiers #1708

wants to merge 2 commits into from

Conversation

Mailaender
Copy link
Contributor

eselmeister
eselmeister reviewed Mar 20, 2024
View reviewed changes
...clipse/chemclipse/chromatogram/xxd/calculator/supplier/amdiscalri/impl/AlkaneIdentifier.java
@@ -40,7 +40,7 @@

public class AlkaneIdentifier {

public static final String IDENTIFIER = "Alkanes Identifier"; // $NON-NLS-N$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep Identifier

eselmeister
eselmeister reviewed Mar 20, 2024
View reviewed changes
...s/org.eclipse.chemclipse.model/src/org/eclipse/chemclipse/model/targets/TargetValidator.java
@@ -23,7 +23,7 @@

public class TargetValidator implements IValidator<Object> {

public static final String IDENTIFIER = "Manual";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep Identifier

eselmeister
eselmeister reviewed Mar 20, 2024
View reviewed changes
...plier.nist/src/org/eclipse/chemclipse/msd/identifier/supplier/nist/runtime/INistSupport.java
@@ -20,7 +20,8 @@ public interface INistSupport {
*/
String NIST_IDENTIFIER_LEGACY_1 = "NIST"; // $NON-NLS-N$
String NIST_IDENTIFIER_LEGACY_2 = "NIST (external)"; // $NON-NLS-N$
String NIST_IDENTIFIER = "NIST (extern)"; // $NON-NLS-N$
String NIST_IDENTIFIER_LEGACY_3 = "NIST (extern)"; // $NON-NLS-N$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep Identifier

eselmeister
eselmeister reviewed Mar 20, 2024
View reviewed changes
...l.fragment.test/src/org/eclipse/chemclipse/model/identifier/IdentificationTarget_1_Test.java
@@ -48,8 +48,8 @@ public void test2() {

public void test3() {

identificationTarget.setIdentifier("ChemClipse");
assertEquals("ChemClipse", identificationTarget.getIdentifier());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary to change this test.

@eselmeister
Copy link
Contributor

Keep the identifier as they are, otherwise the ILibraryService to retrieve the reference spectrum would fail again:

private static final String IDENTIFIER = "Scan Maxima Detector UI"; // $NON-NLS-N$
public static final String IDENTIFIER = "Alkanes Identifier"; // $NON-NLS-N$
public static final String IDENTIFIER = "Manual"; // $NON-NLS-N$
String NIST_IDENTIFIER = "NIST (extern)"; // $NON-NLS-N$

Example file saved with Alkanes Identifier:

Screenshot from 2024-03-20 17-03-43

Identifier changed to org.eclipse.chemclipse.chromatogram.xxd.calculator.supplier.amdiscalri leads to a missing "Comparison Scan" reference:

Screenshot from 2024-03-20 17-05-13

@Mailaender Mailaender marked this pull request as draft March 20, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eselmeister eselmeister eselmeister left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mailaender @eselmeister