-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use release #371
base: main
Are you sure you want to change the base?
Use release #371
Conversation
PR missing one of the required labels: {'breaking-change', 'bug', 'enhancement', 'documentation', 'internal', 'new feature', 'dependencies'} |
Hello @nim65s! I appreciate the thought, but the release workflow for zenoh-python only bumps the version in a dedicated release branch: https://github.com/eclipse-zenoh/zenoh-python/tree/release/1.0.0. The version in the Unless there is anything else to discuss or I missed something, I think we can safely close this pull request. |
PR missing one of the required labels: {'breaking-change', 'bug', 'internal', 'dependencies', 'new feature', 'documentation', 'enhancement'} |
Thanks @fuzzypixelz for the answer ! My issue is that I'm trying to publish zenoh & zenoh-python on nixpkgs, and it prefers not to have any git dependencies in Cargo.lock, as this make the computation of a proper hash for sources of the package quite harder. Would it make sense to integrate this constraint in your release workflow ? Basically I would only need that for the release tag, I understand that afterwards it could make sense to switch back to some development setting. |
The For packaging then the release branch should be used. |
Could you elaborate on this? What issues are you running into exactly? Are you using cargo2nix? As @Mallets pointed out, the Cargo reference has this to say:
Perhaps the "local use" coincides with your Nix packaging process, but I'm not sure. If you provide more information about your issue we can better understand what can/should be done. |
Hi,
The cargo.toml / cargo.lock files use git dependencies, but https://crates.io/crates/zenoh/1.0.0 is out :)