Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: code base now uses DPS #1146

Conversation

paullatzelsperger
Copy link
Contributor

WHAT

This PR adapts the code base (and most significantly: the tests) to work with DataPlane Signaling.
In addition, the edc-tests module was restructured so that it now hosts several submodules, each of which contain
focused test cases. This also improves test runtime due to an expected higher level of parallelization (matrix test).

WHY

Briefly state why the change was necessary.

FURTHER NOTES

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Closes #1141

@paullatzelsperger paullatzelsperger added refactoring Refactoring, does not add functionality critical All issues that will definitely be in the milestone they are planned for labels Mar 20, 2024
Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓

@paullatzelsperger paullatzelsperger force-pushed the refactor/cleanup_obsolete_modules branch from a0044e7 to 84bd04b Compare March 20, 2024 16:36
@paullatzelsperger paullatzelsperger force-pushed the refactor/cleanup_obsolete_modules branch from 864859c to bc21b43 Compare March 20, 2024 19:19
@paullatzelsperger paullatzelsperger force-pushed the refactor/cleanup_obsolete_modules branch from c87d275 to 10d838c Compare March 20, 2024 20:04
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.2% Duplication on New Code

See analysis details on SonarCloud

@paullatzelsperger paullatzelsperger marked this pull request as ready for review March 20, 2024 20:20
@paullatzelsperger paullatzelsperger changed the title refactor: cleanup tests to work with DPS refactor: code base now uses DPS Mar 20, 2024
@paullatzelsperger paullatzelsperger merged commit 19c7866 into eclipse-tractusx:main Mar 20, 2024
32 checks passed
@paullatzelsperger paullatzelsperger deleted the refactor/cleanup_obsolete_modules branch March 20, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical All issues that will definitely be in the milestone they are planned for refactoring Refactoring, does not add functionality
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Cleanup of old EDR implementation (modules, tests, etc)
2 participants