-
Notifications
You must be signed in to change notification settings - Fork 55
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: credential based identity extractor (#1164)
* feat: moves identity extractor from tests to iatp lib + tests * chore: dependencies file
- Loading branch information
Showing
13 changed files
with
194 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,4 +23,5 @@ plugins { | |
|
|
||
| dependencies { | ||
| implementation(libs.edc.spi.core) | ||
| implementation(libs.edc.spi.identitytrust) | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
...tp/tx-iatp/src/test/java/org/eclipse/tractusx/edc/iam/iatp/IatpIdentityExtensionTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| /******************************************************************************** | ||
| * Copyright (c) 2024 Bayerische Motoren Werke Aktiengesellschaft (BMW AG) | ||
| * | ||
| * See the NOTICE file(s) distributed with this work for additional | ||
| * information regarding copyright ownership. | ||
| * | ||
| * This program and the accompanying materials are made available under the | ||
| * terms of the Apache License, Version 2.0 which is available at | ||
| * https://www.apache.org/licenses/LICENSE-2.0. | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations | ||
| * under the License. | ||
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| ********************************************************************************/ | ||
|
|
||
| package org.eclipse.tractusx.edc.iam.iatp; | ||
|
|
||
| import org.eclipse.edc.junit.extensions.DependencyInjectionExtension; | ||
| import org.eclipse.edc.spi.agent.ParticipantAgentService; | ||
| import org.eclipse.edc.spi.system.ServiceExtensionContext; | ||
| import org.eclipse.tractusx.edc.iam.iatp.identity.IatpIdentityExtractor; | ||
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.extension.ExtendWith; | ||
|
|
||
| import static org.mockito.ArgumentMatchers.isA; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.verify; | ||
|
|
||
| @ExtendWith(DependencyInjectionExtension.class) | ||
| public class IatpIdentityExtensionTest { | ||
|
|
||
| private final ParticipantAgentService participantAgentService = mock(); | ||
|
|
||
| @BeforeEach | ||
| void setup(ServiceExtensionContext context) { | ||
| context.registerService(ParticipantAgentService.class, participantAgentService); | ||
| } | ||
|
|
||
| @Test | ||
| void initialize(ServiceExtensionContext context, IatpIdentityExtension extension) { | ||
| extension.initialize(context); | ||
| verify(participantAgentService).register(isA(IatpIdentityExtractor.class)); | ||
| } | ||
|
|
||
| } |
110 changes: 110 additions & 0 deletions
110
...p/src/test/java/org/eclipse/tractusx/edc/iam/iatp/identity/IatpIdentityExtractorTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| /******************************************************************************** | ||
| * Copyright (c) 2024 Bayerische Motoren Werke Aktiengesellschaft (BMW AG) | ||
| * | ||
| * See the NOTICE file(s) distributed with this work for additional | ||
| * information regarding copyright ownership. | ||
| * | ||
| * This program and the accompanying materials are made available under the | ||
| * terms of the Apache License, Version 2.0 which is available at | ||
| * https://www.apache.org/licenses/LICENSE-2.0. | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations | ||
| * under the License. | ||
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| ********************************************************************************/ | ||
|
|
||
| package org.eclipse.tractusx.edc.iam.iatp.identity; | ||
|
|
||
| import org.eclipse.edc.identitytrust.model.CredentialSubject; | ||
| import org.eclipse.edc.identitytrust.model.Issuer; | ||
| import org.eclipse.edc.identitytrust.model.VerifiableCredential; | ||
| import org.eclipse.edc.spi.EdcException; | ||
| import org.eclipse.edc.spi.iam.ClaimToken; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.extension.ExtensionContext; | ||
| import org.junit.jupiter.params.ParameterizedTest; | ||
| import org.junit.jupiter.params.provider.Arguments; | ||
| import org.junit.jupiter.params.provider.ArgumentsProvider; | ||
| import org.junit.jupiter.params.provider.ArgumentsSource; | ||
|
|
||
| import java.time.Instant; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.stream.Stream; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.assertj.core.api.Assertions.assertThatThrownBy; | ||
| import static org.eclipse.edc.spi.agent.ParticipantAgent.PARTICIPANT_IDENTITY; | ||
| import static org.eclipse.tractusx.edc.edr.spi.CoreConstants.CX_CREDENTIAL_NS; | ||
|
|
||
| class IatpIdentityExtractorTest { | ||
|
|
||
| private static final String IDENTITY = "identity"; | ||
| private final IatpIdentityExtractor extractor = new IatpIdentityExtractor(); | ||
|
|
||
| private static VerifiableCredential vc(String type, Map<String, Object> claims) { | ||
| return VerifiableCredential.Builder.newInstance().type(type) | ||
| .issuanceDate(Instant.now()) | ||
| .issuer(new Issuer("issuer", Map.of())) | ||
| .credentialSubject(CredentialSubject.Builder.newInstance().claims(claims).build()) | ||
| .build(); | ||
| } | ||
|
|
||
| @ParameterizedTest | ||
| @ArgumentsSource(VerifiableCredentialArgumentProvider.class) | ||
| void attributesFor(VerifiableCredential credential) { | ||
| var attributes = extractor.attributesFor(ClaimToken.Builder.newInstance().claim("vc", List.of(credential)).build()); | ||
| assertThat(attributes).containsEntry(PARTICIPANT_IDENTITY, IDENTITY); | ||
| } | ||
|
|
||
| @Test | ||
| void attributesFor_Fails_WhenCredentialNotFound() { | ||
| assertThatThrownBy(() -> extractor.attributesFor(ClaimToken.Builder.newInstance().claim("vc", List.of(vc("FooCredential", Map.of("foo", "bar")))).build())) | ||
| .isInstanceOf(EdcException.class) | ||
| .hasMessageContaining("Failed to fetch"); | ||
| } | ||
|
|
||
| @Test | ||
| void attributesFor_Fails_whenNoVcClaims() { | ||
| assertThatThrownBy(() -> extractor.attributesFor(ClaimToken.Builder.newInstance().build())) | ||
| .isInstanceOf(EdcException.class) | ||
| .hasMessageContaining("Failed to fetch credentials from the claim token: ClaimToken did not contain a 'vc' claim"); | ||
| } | ||
|
|
||
| @Test | ||
| void attributesFor_Fails_whenNullVcClaims() { | ||
|
|
||
| assertThatThrownBy(() -> extractor.attributesFor(ClaimToken.Builder.newInstance().claim("vc", null).build())) | ||
| .isInstanceOf(EdcException.class) | ||
| .hasMessageContaining("Failed to fetch credentials from the claim token: ClaimToken did not contain a 'vc' claim"); | ||
| } | ||
|
|
||
| @Test | ||
| void attributesFor_Fails_WhenVcClaimIsNotList() { | ||
| assertThatThrownBy(() -> extractor.attributesFor(ClaimToken.Builder.newInstance().claim("vc", "wrong").build())) | ||
| .isInstanceOf(EdcException.class) | ||
| .hasMessageContaining("Failed to fetch credentials from the claim token: ClaimToken contains a 'vc' claim, but the type is incorrect. Expected java.util.List, got java.lang.String."); | ||
| } | ||
|
|
||
| @Test | ||
| void attributesFor_Fails_WhenVcClaimsIsEmptyList() { | ||
| assertThatThrownBy(() -> extractor.attributesFor(ClaimToken.Builder.newInstance().claim("vc", List.of()).build())) | ||
| .isInstanceOf(EdcException.class) | ||
| .hasMessageContaining("Failed to fetch credentials from the claim token: ClaimToken contains a 'vc' claim but it did not contain any VerifiableCredentials."); | ||
| } | ||
|
|
||
| private static class VerifiableCredentialArgumentProvider implements ArgumentsProvider { | ||
| @Override | ||
| public Stream<? extends Arguments> provideArguments(ExtensionContext context) { | ||
| return Stream.of( | ||
| Arguments.of(vc("MembershipCredential", Map.of("holderIdentifier", IDENTITY))), | ||
| Arguments.of(vc(CX_CREDENTIAL_NS + "MembershipCredential", Map.of("holderIdentifier", IDENTITY))), | ||
| Arguments.of(vc(CX_CREDENTIAL_NS + "MembershipCredential", Map.of(CX_CREDENTIAL_NS + "holderIdentifier", IDENTITY)))); | ||
| } | ||
|
|
||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters