Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): delete connector when sdFactory is disabled #1222

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tfjanjua
Copy link
Contributor

@tfjanjua tfjanjua commented Jan 6, 2025

Description

Please include a summary of the change.

Why

Please include an explanation of why this change is necessary as well as relevant motivation and context. List any dependencies that are required for this change.

Issue

Ref: #1221

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@tfjanjua tfjanjua requested review from Phil91 and ntruchsess January 6, 2025 07:13
@tfjanjua tfjanjua self-assigned this Jan 6, 2025
@tfjanjua tfjanjua added the bug Something isn't working label Jan 6, 2025
Copy link

sonarqubecloud bot commented Jan 6, 2025

@Phil91 Phil91 self-assigned this Jan 7, 2025
@tfjanjua tfjanjua requested a review from Phil91 January 8, 2025 09:42
Copy link
Member

@Phil91 Phil91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some unit tests to test the case of the deletion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: IN PROGRESS
Development

Successfully merging this pull request may close these issues.

2 participants