fix(Pool): duplicate BPN request identifier mapping entries #1173
+25
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove duplicate BPN request identifier mappings form the database - Prevent creation of new duplicates - Fix the request identifier unique constraint so that an exception will be thrown when a duplicate entry tries to be created in the database (just for data integrity, should not happen in normal logic)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes the Pool's behaviour of creating duplicate BPN request identifier mapping entries
Fixes #1159
How to test
In order to check the behaviour you can create a business partner with site information via the Gate, full golden record process. Then provide an update to that business partner without changing the names or BPNs (for example change a small field in the address). Look into the database, there should be no duplicate entries. In the previous version you should see a duplicate.
Please fill free to execute further test scenarios.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: