feat(Gate): add business partner relations #1167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoprow
force-pushed
the
feat/managed-by-relations
branch
from
6c3500b to
fa0c8ec
Compare
nicoprow
added
enhancement
nicoprow
force-pushed
the
feat/managed-by-relations
branch
from
fa0c8ec to
636f67c
Compare
SujitMBRDI
requested changes
Jan 6, 2025
There was a problem hiding this comment.
Great logic and code changes!!
Changes looks good to me, tests i have performed:
- From gate input, I have provided two legal entities
- Then created relations using tenant null
- Then deleted relationship too.
As we discussed in review session, just we need to swap logic for Source and Target as IsManagedBy is passive term.
nicoprow
force-pushed
the
feat/managed-by-relations
branch
2 times, most recently
from
18ec529 to
9b6ff0c
Compare
- add new endpoints to search, create, update and delete business partner relations - add logic for CRUD and constraint checking - add database table for relations - add tests
nicoprow
force-pushed
the
feat/managed-by-relations
branch
from
9b6ff0c to
a20ab68
Compare
|
I changed the constraints on the IsManagedBy relation as discussed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds new endpoints to search, create, update and delete business partner relations.
It currently supports only the IsManagedBy relation type.
Contributes to #1027
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: