-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added inbuilt PDF viewer #103
base: master
Are you sure you want to change the base?
Conversation
Can one of the admins verify this patch? |
Thanks for the patch! What is the license on this component? |
@turesheim : I added this : https://marketplace.eclipse.org/content/gnostice-free-pdfnoffice-viewer-eclipse-plugin
|
do you think we can use this ? |
I'm afraid the answer is no. At least not without getting approval from the Board of Directors. This is not in the list of pre-approved licenses https://www.eclipse.org/legal/licenses.php and is not even a OSI-approved license. |
Hello @hgvanpariya If this PR is still actual, you can try to run https://github.com/eclipse/dash-licenses on it locally to inspect licensing issues. |
Added PDFViewer : gnostice
It will add PDF viewer inside eclipse. #84