Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow github actions to deploy to github artifacts registry #3

Closed
wants to merge 1 commit into from

Conversation

AxelRICHARD
Copy link
Member

No description provided.

@AxelRICHARD AxelRICHARD requested review from a team as code owners December 22, 2023 08:19

This comment has been minimized.

Copy link

Diff for abf3882:
Printing local diff:

Actions are indicated with the following symbols:
+   create
!   modify
!   forced update
-   delete

Organization eclipse-syson[id=eclipse-syson]
  there have been 2 validation infos, enable verbose output with '-v' to to display them.

  
!   org_workflow_settings {
!     default_workflow_permissions                             = "read" -> "write"
!   }

  
!   repo_workflow_settings[repository="syson"] {
!     default_workflow_permissions                             = "read" -> "write"
!   }
  
  Plan: 0 to add, 2 to change, 0 to delete.
Canonical Diff for abf3882:
Showing canonical diff:

Organization �[1meclipse-syson�[0m[id=eclipse-syson]

@netomi
Copy link
Contributor

netomi commented Dec 22, 2023

The organization defines read permissions for tokens by default. You can assign specific permissions in your workflow for specific jobs, see:

https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

That is the preferred way to do it instead of enabling write permissions by default which would also have to be enabled on organization level first.

@netomi
Copy link
Contributor

netomi commented Dec 22, 2023

In the long run we would like to enforce read permissions by default for every Eclipse project. Here you can see some example how you define that job level permissions:

https://github.com/eclipse-sprotty/sprotty-website/blob/main/.github/workflows/preview.yml

@AxelRICHARD
Copy link
Member Author

Thank you, but I would like this way to be consistent with our other repositories like eclipse-sirius.

@AxelRICHARD
Copy link
Member Author

Ok I will update my workflows, thank you.

@AxelRICHARD AxelRICHARD deleted the github-write branch December 22, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants