Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-5121: support empty left bind join (OPTIONAL) in FedX #5200

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

aschwarte10
Copy link
Contributor

@aschwarte10 aschwarte10 commented Nov 12, 2024

GitHub issue resolved: #5121

Previously we introduced support for left bind joins in FedX. The case
of empty left bind joins (i.e. where the clause inside the OPTIONAL does
not provide any statements) was not handled and resulted in an exception

This change now adds support for empty optional joins and passes the
results from the left-handside through.


Note: this is a follow up issue and fix for #5121, which we found by using RDF4J 5.1-M1. The fix should be added to 5.1.0


PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

Previously we introduced support for left bind joins in FedX. The case
of empty left bind joins (i.e. where the clause inside the OPTIONAL does
not provide any statements) was not handled and resulted in an exception

This change now adds support for empty optional joins and passes the
results from the left-handside through.
@aschwarte10 aschwarte10 added this to the 5.1.0 milestone Nov 12, 2024
@aschwarte10 aschwarte10 changed the base branch from main to develop November 12, 2024 09:12
@aschwarte10 aschwarte10 merged commit 1339109 into develop Nov 14, 2024
9 checks passed
@aschwarte10 aschwarte10 deleted the GH-5121-fix-bind-left-join-empty-pattern branch November 14, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support bind left joins in FedX federation engine (optimization for OPTIONAL)
2 participants