Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-4232 performance issue in VALUES clause query #4330

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

GH-4232 performance issue in VALUES clause query #4330

wants to merge 4 commits into from

Commits on Jan 20, 2023

  1. GH-4232 ensure VALUES clause always covers entire group graph pattern 

    This is the generically correct way to parse VALUES clauses. An
optimizer can potentially look at the ordering in the algebra to push
the values clause down into the join tree (by inspecting which parts of
the tree have variables bound in the VALUES clause).
    @abrokenjester
    abrokenjester committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    e1c6042 View commit details
    Browse the repository at this point in the history

  2. GH-4232 benchmark to try and reproduce perf difference 

    This benchmark uses generated data conforming to the query pattern, and
executes performance tests on both the variant with a VALUES clause, and
(as a baseline) the simple equivalent query.

Unfortunately, sofar I have been unable to reproduce any significant performance difference.
    @abrokenjester
    abrokenjester committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    4fb24b2 View commit details
    Browse the repository at this point in the history

  3. GH-4232 updated benchmark to reproduce the issue

    @hmottestad @abrokenjester
    hmottestad authored and abrokenjester committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    818fe45 View commit details
    Browse the repository at this point in the history

  4. GH-4232 added regression test for debugging purposes

    @abrokenjester
    abrokenjester committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    7794d0f View commit details
    Browse the repository at this point in the history