Skip to content

Commit

Permalink
Always add a version if exporting a package #1426
Browse files Browse the repository at this point in the history
Changed the default for get version to always return a version even if file is unversioned. Defaults at 1.0.0
  • Loading branch information
EverettHanke authored and laeubi committed Dec 27, 2024
1 parent 2c1860a commit cdba88c
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ private static String getVersion(ExportPackageDescription desc) {
"[" + version.getMajor() + "." + version.getMinor() + "," + (version.getMajor() + 1) + ")") //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$//$NON-NLS-4$
.toString();
}
return null;
return "[1.0.0)";

Check warning on line 42 in ui/org.eclipse.pde.core/text/org/eclipse/pde/internal/core/text/bundle/ImportPackageObject.java

View check run for this annotation

Jenkins - eclipse-pde / Compiler and API Tools

NLS

NORMAL: $ Non-externalized string literal; it should be followed by //$NON-NLS-
}

public ImportPackageObject(ManifestHeader header, ManifestElement element, String versionAttribute) {
Expand Down

0 comments on commit cdba88c

Please sign in to comment.