Add comments to JIT recognized methods for encoding/decoding #20864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds comments to some encoding/decoding methods that are recognized by the JIT. Only limited Java versions use these methods.
|
See PR #20520 for the background. |
|
Jenkins compile xlinux jdk11 |
hzongaro
reviewed
Jan 6, 2025
Comment on lines
+3779
to
+3787
| {x(TR::sun_nio_cs_ISO_8859_1_Decoder_decodeISO8859_1, "decodeISO8859_1", "([BII[CI)I")}, // Used in IBM SDK | ||
| {x(TR::sun_nio_cs_US_ASCII_Encoder_encodeASCII, "encodeASCII", "([CII[BI)I")}, // Used in Java 8 and 11 | ||
| {x(TR::sun_nio_cs_US_ASCII_Decoder_decodeASCII, "decodeASCII", "([BII[CI)I")}, // Used in Java 8 and 11 | ||
| {x(TR::sun_nio_cs_ext_SBCS_Encoder_encodeSBCS, "encodeSBCS", "([CII[BI[B)I")}, // Used in IBM SDK | ||
| {x(TR::sun_nio_cs_ext_SBCS_Decoder_decodeSBCS, "decodeSBCS", "([BII[CI[C)I")}, // Used in IBM SDK | ||
| {x(TR::sun_nio_cs_UTF_8_Encoder_encodeUTF_8, "encodeUTF_8", "([CII[BI)I")}, // Used in IBM SDK | ||
| {x(TR::sun_nio_cs_UTF_8_Decoder_decodeUTF_8, "decodeUTF_8", "([BII[CI)I")}, // Used in IBM SDK | ||
| {x(TR::sun_nio_cs_UTF16_Encoder_encodeUTF16Big, "encodeUTF16Big", "([CII[BI)I")}, // Used in IBM SDK | ||
| {x(TR::sun_nio_cs_UTF16_Encoder_encodeUTF16Little, "encodeUTF16Little", "([CII[BI)I")}, // Used in IBM SDK |
There was a problem hiding this comment.
I do agree. As most of these methods shipped as in JCL in IBM SDK 8. It should be present on all platforms though (It is a different story if platform recognize and accelerates it or not).
There was a problem hiding this comment.
So what kind of changes do you want me to make?
Updating the comment "Used in IBM SDK" to "Used in IBM SDK Java 8"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds comments to some encoding/decoding methods that are recognized by the JIT.
Only limited Java versions use these methods.