Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: add findResourceFor(URI) cache to SymbolsLabelProvider #907 #1172

Merged
merged 1 commit into from
Jan 13, 2025
Merged

perf: add findResourceFor(URI) cache to SymbolsLabelProvider #907 #1172

merged 1 commit into from
Jan 13, 2025

Conversation

sebthom
Copy link
Contributor

@sebthom sebthom commented Jan 12, 2025 •
edited
Loading

This caches the repeated findResourceFor(URI) calls in SymbolsLabelProvider.getImage() that can result in performance issues as described in #907

rubenporras
rubenporras approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@rubenporras rubenporras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

rubenporras
rubenporras requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@rubenporras rubenporras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen that while I was reviewing posted some questions. I think it makes sense to take back my approval so that we do not have conflicting reviews.

@sebthom sebthom merged commit 308d167 into eclipse-lsp4e:main Jan 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickaelistria mickaelistria mickaelistria approved these changes

@rubenporras rubenporras Awaiting requested review from rubenporras

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebthom @mickaelistria @rubenporras