feat: support auto folding of comments and add folding preferences page #1171
Conversation
| public static final String PREF_AUTOFOLD_REGIONS = "foldingReconcilingStrategy.collapseRegions"; //$NON-NLS-1$ | ||
| public static final String PREF_AUTOFOLD_IMPORT_STATEMENTS = "foldingReconcilingStrategy.collapseImports"; //$NON-NLS-1$ | ||
|
|
||
| public static final class PreferenceInitializer extends AbstractPreferenceInitializer { |
There was a problem hiding this comment.
Is initializing the preferences to some value the preferred pattern? I think org.eclipse.lsp4e.ui.LoggingPreferencePage does not initialize its preferences, rather it relies on the defaults of IPreferenceStore.getBoolean. I think this is better because one can change the defaults in LSP4E any time and they will be changed for users as well unless they have set the values themselves. Do you agree with that or do you think it is better to initialize the values? Why then?
There was a problem hiding this comment.
I don't know what the preferred way is TBH. I used it because one pref key needs a default value of true and with the initializer I have a single place to define it.
|
@mickaelistria , do you know if there is a preferred way? (see my comment above) |
|
One can set preference in a preference initializer, that's the right pattern. |
This PR implements auto folding for comments and regions and adds this new settings page:
This is a follow-up PR to #971 and solves #895 and #927