refact: improve null analysis #1095
Conversation
org.eclipse.lsp4e/src/org/eclipse/lsp4e/LanguageServerWrapper.java
Outdated
Show resolved
Hide resolved
org.eclipse.lsp4e.debug/src/org/eclipse/lsp4e/debug/debugmodel/DSPBreakpointManager.java
Show resolved
Hide resolved
| @@ -279,15 +279,15 @@ private static List<ICompletionProposal> toProposals(IDocument document, int off | |||
| public IContextInformation @Nullable [] computeContextInformation(ITextViewer viewer, int offset) { | |||
| IDocument document = viewer.getDocument(); | |||
| if (document == null) { | |||
| return new IContextInformation[] { /* TODO? show error in context information */ }; | |||
| return null; /* TODO? show error in context information */ | |||
There was a problem hiding this comment.
this changes to return null seem to make the code more inline with the documentation of the method we are overriding, and I think it would be nice to have a separate PR for them that we can merge independently.
org.eclipse.lsp4e.debug/src/org/eclipse/lsp4e/debug/launcher/DSPLaunchDelegate.java
Outdated
Show resolved
Hide resolved
org.eclipse.lsp4e.jdt/src/org/eclipse/lsp4e/jdt/LSJavaCompletionProposalComputer.java
Show resolved
Hide resolved
|
@sebthom , if you like to do a new PR with the three changes which are clear and not just flipping annotations, I think that would be good. |
|
@rubenporras we need a new approval from IP team, see https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/16066 I hope that happens soon. |
Yes I already opened a ticket. see my previous ocmment. |
Sorry, I cross-posted. |
This PR bumps no-npe to version 1.1.0 (which contains more refined external null annotation) and applies all necessary code changes to satisfy null analysis checks by the Eclipse compiler.
This PR bumps no-npe to version 1.1.0 (which contains more refined external null annotation) and applies all necessary code changes to satisfy null analysis checks by the Eclipse compiler.