Skip to content

Commit

Permalink
fix: GHA builds on MacOS fail
Browse files Browse the repository at this point in the history
  • Loading branch information
sebthom committed Dec 19, 2024
1 parent bc43eb5 commit 9c861ca
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,9 @@ jobs:
strategy:
fail-fast: false
matrix:
os:
# https://github.com/actions/runner-images#available-images
os: # https://github.com/actions/runner-images#available-images
#- ubuntu-latest # TODO builds are extremely slow for no apparent reason and job currently times out after 15 minutes
- macos-12 # Intel
- macos-13 # Intel
- macos-14 # ARM
- windows-latest
runs-on: ${{ matrix.os }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public void testRenameHandlerEnablement() throws Exception {

@Test
public void testAsyncRenameHandlerEnablement() throws Exception {
final int delay = 2_000;
final int delay = 4_000;
// this fixed value is not really an optimal solution, since it depends on the following things
// to happen within that time frame. Should maybe re-work this in the future towards a more
// precise way of steering the execution from the test here
Expand All @@ -91,10 +91,10 @@ public void testAsyncRenameHandlerEnablement() throws Exception {
ICommandService commandService = PlatformUI.getWorkbench().getService(ICommandService.class);
Command command = commandService.getCommand(IWorkbenchCommandConstants.FILE_RENAME);
assertFalse(command.isEnabled());

editor.selectAndReveal(1, 0);

waitForAndAssertCondition(3 * delay, () -> command.isEnabled());
waitForAndAssertCondition(2 * delay, command::isEnabled);
assertTrue(command.isHandled());
} finally {
// Put back so shutdown doesn't time out
Expand Down

0 comments on commit 9c861ca

Please sign in to comment.