Ensure Gradle project reacts to build configuration changes.

[snjeza]

Fixes redhat-developer/vscode-java#3893

[rgrunber]

• This fixes the issue, but I noticed a small bug this introduces.

If I set the "java.configuration.updateBuildConfiguration": "interactive" (this is where the issue occurs) and make a change in the build file, this updates the build before I answer the prompt. This is described at redhat-developer/vscode-java#3893 (comment) . It existed even before.

Screencast.From.2025-01-06.12-06-16.mp4

• I wasn't sure why you touched any logic in the automatic case because for me the issue is only reproducible when the build configuration is set to interactive. I did however notice that when going from interactive -> automatic it didn't seem to respect/update the build. Is that what you're trying to fix as well ?

[snjeza]

I wasn't sure why you touched any logic in the automatic case because for me the issue is only reproducible when the build configuration is set to interactive.

The issue is reproducible when you set

auto.sync=false

to <project>/.settings/org.eclipse.buildship.core.prefs regardless of whether java.configuration.updateBuildConfiguration is interactive or automatic.

If I set the "java.configuration.updateBuildConfiguration": "interactive" (this is where the issue occurs) and make a change in the build file, this updates the build before I answer the prompt.

checking...
I can't reproduce this issue

[snjeza]

my vscode-java-import/app/.settings/org.eclipse.buildship.core.prefs

arguments=--init-script /home/snpe/projects/eclipse.jdt.ls/org.eclipse.jdt.ls.core/gradle/init/init.gradle --init-script /home/snpe/projects/eclipse.jdt.ls/org.eclipse.jdt.ls.core/gradle/protobuf/init.gradle
auto.sync=false
build.scans.enabled=false
connection.gradle.distribution=GRADLE_DISTRIBUTION(VERSION(8.9))
connection.project.dir=
eclipse.preferences.version=1
gradle.user.home=
java.home=/usr/lib/jvm/java-17-openjdk
jvm.arguments=
offline.mode=false
override.workspace.settings=true
show.console.view=true
show.executions.view=true

[rgrunber]

Maybe I didn't describe it correctly. I think the PR fixes things, but it makes the case more clear that when you import the sample project as automatic, then change to interactive, you can change the build file, and save, but the build gets updated before responding to the interactive popup.

In my original video, I didn't show the project first loaded as automatic, and then switching to interactive.

[snjeza]

Maybe I didn't describe it correctly. I think the PR fixes things, but it makes the case more clear that when you import the sample project as automatic, then change to interactive, you can change the build file, and save, but the build gets updated before responding to the interactive popup.
In my original video, I didn't show the project first loaded as automatic, and then switching to interactive.

@rgrunber I have fixed this issue. Could you, please, check it again?

[rgrunber]

Looks pretty good to me. Just some minor things to confirm.