Add capability to list all vm installs and update project jdk #2977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sheng Chen <[email protected]>
rgrunber
reviewed
Nov 27, 2023
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/commands/ProjectCommand.java
Outdated
Show resolved
Hide resolved
testforstephen
approved these changes
Nov 28, 2023
rgrunber
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Looks fine to me. Feel free to merge when ready. I would just fix #2977 (comment) .
Signed-off-by: Sheng Chen <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two delegate command is added:
java.vm.getAllInstalls- Get all vm installs.java.project.updateJdk- Update the given project's jdk.They will be used by the configure classpath webview at client side.
related with microsoft/vscode-java-pack#1263