Fix the error 'Invalid project description' caused by incorrect glob patterns for Windows paths #2911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…patterns for Windows paths Signed-off-by: Jinbo Wang <[email protected]>
testforstephen
commented
Oct 18, 2023
Comment on lines
+555
to
+559
| File[] files = projectDir.listFiles((FilenameFilter) (dir, name) -> { | ||
| if (name != null && GradleBuildSupport.GRADLE_FILE_EXT.matcher(name).matches()) { | ||
| return new File(dir, name).lastModified() > modified; | ||
| } | ||
| return false; |
There was a problem hiding this comment.
This code change is introduced by the cleanup actions.
|
test this please |
jdneo
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2845
It's a Windows specific bug. The root cause for the error 'Invalid project description' is that some importer fails to exclude the already imported projects during scanning, and attempts to import the same projects again. The fix is to exclude the already imported projects from scanning by using valid glob patterns for Windows paths.