Migration to junit 5 #1725
Open
Migration to junit 5 #1725
+638
−720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carstenartur
force-pushed
the
testjunit5migration
branch
from
f89dd86
to
162b9d7
Compare
carstenartur
force-pushed
the
testjunit5migration
branch
from
1172001
to
4f3b32d
Compare
carstenartur
force-pushed
the
testjunit5migration
branch
from
4f3b32d
to
9f9fa67
Compare
test to run the upcoming junit 4 to junit 5 migration cleanup
carstenartur
force-pushed
the
testjunit5migration
branch
from
9f9fa67
to
2bf7708
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run the upcoming junit 4 to junit 5 migration cleanup
What it does
This Pr changes a bunch of tests from using JUnit 4 to JUnit 5.
It does not change anything at all about how jdt.ui works. Changes are in the testing code only.
However in the testing code it should not change anything neither. The migration from JUnit 4 suites to JUnit 5 suites was able to boost performance a little bit. I am not aware of similar effects in the testing code. So what this Pr gives you is that the affected classes are following a testing pattern using a actively maintained release for the first time in the last 20(?) years.
How to test
Count the number of tests and check results.
Author checklist