-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate some junit 4 suites to junit 5 #1669
Conversation
@akurtakov can you have a look if this is what you suggested? |
813f0dd
to
6eb4dc7
Compare
I haven't done detailed review but this is aligning with the overall idea - make suites JUnit5 ones so individual tests can be added/migrated to JUnit 5 later. |
org.eclipse.jdt.ui.tests/ui/org/eclipse/jdt/ui/tests/jarexport/FatJarExportTests.java
Outdated
Show resolved
Hide resolved
Same number of tests, tests succeed, only a small portion of new code which looks wrong to me. |
org.eclipse.jdt.ui.tests/ui/org/eclipse/jdt/ui/tests/jarexport/FatJarExportTests.java
Outdated
Show resolved
Hide resolved
Hi @akurtakov I did look at it and was waiting for your comments as @carstenartur was asking if it met your expectations. I too noticed that same number of tests ran and succeeded. Does this patch make it possible to have the explicit encoding tests added instead of forcing manual execution? |
…/FatJarExportTests.java Delete accidently changed file
…arexport/FatJarExportTests.java" This reverts commit 44ae547.
92a33eb
to
d50425f
Compare
What it does
As suggested in #1631 (comment) here we have a first try to update the suites from junit 4 to junit 5 so that step by step upgrade of tests to junit 5 or even a mix of junit 4 and junit 5 based tests is possible.
Unfortunately there are two issues currently:
How to test
Author checklist