Add component property type for agent service name property #595
+42
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Component property types are much more expressive and convenient to use than string concatenations and less error prone on refactorings/reference searches. This now adds a new component property type for the 'p2.agent.service.name' and uses it at the place where it previously using the property constant to show usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component property types are much more expressive and convenient to use than string concatenations and less error prone on refactorings/reference searches.
This now adds a new component property type for the
p2.agent.service.nameand uses it at the place where it previously using the property constant to show usage.I also checked for the case now that it produces the same component.xml output