Improve warning message with no digest found #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the message only mentions the artifact to download but not where it originates from, this makes it very hard to analyze and fix the issue (actually one needs to to run a debugger). This enhances the message a tiny little bit to mention the artifact descriptors repository URL.
merks
approved these changes
Mar 28, 2024
| @@ -491,7 +491,8 @@ private OutputStream addPreSteps(ProcessingStepHandler handler, IArtifactDescrip | |||
| addChecksumVerifiers(descriptor, downloadChecksumSteps, skipChecksums, IArtifactDescriptor.DOWNLOAD_CHECKSUM); | |||
| if (downloadChecksumSteps.isEmpty() && !isLocal()) { | |||
| LogHelper.log(new Status(IStatus.WARNING, Activator.ID, | |||
| NLS.bind(Messages.noDigestAlgorithmToVerifyDownload, descriptor.getArtifactKey()))); | |||
There was a problem hiding this comment.
Notice that this call is guarded by `!isLocal()" because of course if the repository is local, this is not a download.
| @@ -94,7 +94,8 @@ protected IStatus getArtifact(IArtifactDescriptor artifactDescriptor, OutputStre | |||
| IArtifactDescriptor.DOWNLOAD_CHECKSUM, Collections.emptySet()); | |||
| if (steps.isEmpty()) { | |||
| LogHelper.log(new Status(IStatus.WARNING, Activator.ID, | |||
| NLS.bind(Messages.noDigestAlgorithmToVerifyDownload, artifactDescriptor.getArtifactKey()))); | |||
| NLS.bind(Messages.noDigestAlgorithmToVerifyDownload, artifactDescriptor.getArtifactKey(), | |||
There was a problem hiding this comment.
I was hoping that we could avoid calling this if the artifact is local. See comment below...
|
I think the reason is because RawMirrorRequest is always against a remote, at least while debugging it really tries to download from a remote. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the message only mentions the artifact to download but not where it originates from, this makes it very hard to analyze and fix the issue (actually one needs to to run a debugger).
This enhances the message a tiny little bit to mention the artifact descriptors repository URL.