-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused distinction between Plug-ins and Fragments in products #378
Remove unused distinction between Plug-ins and Fragments in products #378
Conversation
Never been aware of that one can switch it, I think its there for the same historic reasons it was added to features... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its all internal API and adjustments seems minimal, maybe @merks has some concerns but from Tycho side we will simply adopt.
The PDE Product Editor used to add a 'fragment' attribute to plugin elements in *.product files, but the attribute is unused for a long time. Relates to eclipse-equinox/p2#378
I assume the same about the history.
Here is the PDE pendant: eclipse-pde/eclipse.pde#882
For Tycho I already started a commit locally to adapt to all the internal changes done in P2 in this release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fortunately I don't call the changed methods so it's not a problem.
The PDE Product Editor used to add a 'fragment' attribute to plugin elements in *.product files, but the attribute is unused for a long time. Relates to eclipse-equinox/p2#378
The PDE Product Editor used to add a 'fragment' attribute to plugin elements in *.product files, but the attribute is unused for a long time. Relates to eclipse-equinox/p2#378
Created N&N entry for this: eclipse-platform/www.eclipse.org-eclipse#84 |
Remove unused distinction between Plug-ins and Fragments in
.product
files.There is no usage of a product's fragments in P2 or PDE.
I also checked Tycho (5 but I assume it's the same for Tycho 4) and it never calls
IProductDescriptor.getFragments()
and callsIProductDescriptor.getBundles(boolean includeFragments)
withincludeFragments=true
.So it looks like this distinction is unused and can be removed too.
Consequently PDE support for adding a fragment attribute for fragments listed in a product file can be removed too and I will create a PR dedicated to that.
This was originally part of #368, but since the second part there needs some more adoptions in PDE I will postpone that but would like to land this for the December release.