Fix failing DAP tests on Github Actions #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running tests from Github Actions, there was a race condition between the code handling the "stopped" message and the code that was trying to continue the execution after the end of the test. Sometimes, the test would try to release the "suspendLatch" before it was set, which would result in the "continue" request effectively being ignored by the debug adapter. This commit extends the synchronized block in the suspend() method so any code trying to call resumeAllThreads() while reacting to the "stopped" message will have to wait until the suspendLatch has been enabled and the execution of the Epsilon script has been suspended by having the Thread wait().
agarciadom
force-pushed
the
debug-dap-failures
branch
from
8bb69eb
to
972a9a8
Compare
agarciadom
changed the title
|
Turns out that Github Actions did catch a mistake in our DAP code! The This now passes on Github Actions as well :-). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress PR for debugging the DAP test failures on Github actions. Please do not merge for now.