Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move custom-runtime under advanced folder #180

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Dec 14, 2023

What this PR changes/adds

Move sample under advanced and get rid of other folder

Why it does that

cleanup

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #143

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the refactoring Cleaning up code and dependencies label Dec 14, 2023
Copy link
Contributor

@ronjaquensel ronjaquensel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add the sample to the advanced/README.md?

@ndr-brt ndr-brt merged commit d387790 into eclipse-edc:main Dec 14, 2023
8 of 10 checks passed
@ndr-brt ndr-brt deleted the 143-move-custom-runtime branch December 14, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move custom-runtime sample under advanced
2 participants