refactor(api): expose dataplanes api v4alpha #4704
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
added
refactoring
ndr-brt
force-pushed
the
dataplane-instance-v4alpha
branch
from
09459be to
2724fee
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| .add(TYPE, DataPlaneInstance.DATAPLANE_INSTANCE_TYPE) | ||
| .add(URL, dataPlaneInstance.getUrl().toString()) | ||
| .add(LAST_ACTIVE, dataPlaneInstance.getLastActive()) | ||
| .add(TURN_COUNT, dataPlaneInstance.getTurnCount()); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| var srcBldr = jsonFactory.createArrayBuilder(dataPlaneInstance.getAllowedSourceTypes()); | ||
| builder.add(ALLOWED_SOURCE_TYPES, srcBldr); | ||
|
|
||
| var dstBldr = jsonFactory.createArrayBuilder(dataPlaneInstance.getAllowedDestTypes()); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
ndr-brt
force-pushed
the
dataplane-instance-v4alpha
branch
from
2724fee to
f43032a
Compare
ndr-brt
force-pushed
the
dataplane-instance-v4alpha
branch
from
f43032a to
a257c96
Compare
ndr-brt
force-pushed
the
dataplane-instance-v4alpha
branch
from
a257c96 to
d82f132
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Exposes
/dataplanesv4alpha withoutv3deprecated fieldsWhy it does that
prepare for new version, get rid of deprecated stuff
Further notes
v2will be removedLinked Issue(s)
Part of #4659
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.