refactor: introduce PortMappingRegistry service #4677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
requested review from
bscholtes1A,
jimmarino,
paullatzelsperger,
ronjaquensel and
juliapampus
as code owners
ndr-brt
force-pushed
the
refactor-port-mappings
branch
from
450e40d to
551a4bd
Compare
ndr-brt
force-pushed
the
refactor-port-mappings
branch
from
551a4bd to
53511b7
Compare
jimmarino
reviewed
Dec 16, 2024
will to after merge, I am already preparing the change |
jimmarino
reviewed
Dec 16, 2024
ndr-brt
changed the title
jimmarino
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Following up #4671 :
Adds a
PortMappingRegistryservice, to centralize thePortMappingregistration.Makes use of
@Configurationand@Settingsannotation to define api configuration, makingWebServiceConfigurernot needed (it has been deprecated)Why it does that
refactor
Further notes
JettyServicestart method a little, the mappings validations have been moved onPortMappings(so the runtime would crash earlier in case of inconsistencies, improved methods naming and scopeLinked Issue(s)
Part of #4669
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.